search

WordPress / wordpress.org

WordPress.org Meta, Git-ified. Synced from git://meta.git.wordpress.org/ This repository is just a mirror of the WordPress Meta subversion repository. Please include a link to a pre-existing ticket on https://meta.trac.wordpress.org/ with every pull request.
https://meta.trac.wordpress.org/
109 stars 140 forks source link

Show a notice on login when the user has no recovery codes recorded, is running low, or has logged in with a recovery code. #358

Closed dd32 closed 3 weeks ago

dd32 commented 3 weeks ago

See https://github.com/WordPress/wporg-two-factor/issues/279

This PR shows the following notice when logging in with a recovery code, or is running low on recovery codes.

Login Running low Have no recovery codes
Screenshot 2024-08-16 at 1 11 30 PM Screenshot 2024-08-16 at 1 13 30 PM Screenshot 2024-08-16 at 1 14 23 PM

In the first case, the I'll do this later only shows if the user has at least one more recovery code on the account. I'm not against removing the bypass link entirely though.

I realise that the 2nd and 3rd have a bad orphan, I need some text inspiration :)

StevenDufresne commented 3 weeks ago

This looks good. Our interfaces uses "Backup Codes" as opposed to "Recovery codes". We should remain consistent.

dd32 commented 3 weeks ago

Our interfaces uses "Backup Codes" as opposed to "Recovery codes". We should remain consistent.

I was thinking the same thing. We should probably standardise on Recovery Codes, as that's what we show on the Login page after the upstream rename https://github.com/WordPress/two-factor/pull/521