WordPress / wordpress.org

WordPress.org Meta, Git-ified. Synced from git://meta.git.wordpress.org/ This repository is just a mirror of the WordPress Meta subversion repository. Please include a link to a pre-existing ticket on https://meta.trac.wordpress.org/ with every pull request.
https://meta.trac.wordpress.org/
114 stars 146 forks source link

Unify search fields #384

Open jasmussen opened 2 weeks ago

jasmussen commented 2 weeks ago

Ideally all 1-line input fields are 40px tall. This search on make/core is 38:

Image

The one from make/design looks different:

Image

Ideally they can be the same.

adamwoodnz commented 2 weeks ago

This difference is caused by some blogs using legacy search widgets and some using blocks. Meta for example is using the Search block with the settings to match the other sites, and the Jetpack subscription block with the smaller button:

Image

I was thinking we would update all the sites to use these, look ok to you?

From my testing, functionally they are the same.

jasmussen commented 2 weeks ago

I was thinking we would update all the sites to use these, look ok to you?

Sounds good to me.

adamwoodnz commented 2 days ago

Sites updated

adamwoodnz commented 2 days ago

Note that the mobile site uses the legacy Jetpack search widget, so the search block is not a direct replacement, and it hasn't been updated. The subscription form has though.

adamwoodnz commented 2 days ago

We can't change the handbook search fields to blocks until after launch, as there are functional changes required (modifying the form action), but I've added a task to do this afterward. For now only Meta has custom CSS to switch visibility of the legacy and block fields for testing purposes.