WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

Fix function name in main plugin file #100

Closed tylerdigital closed 4 years ago

tylerdigital commented 4 years ago

It appears that the function got renamed in the functions.php file but didn't get updated in the main plugin file

pbiron commented 4 years ago

Thanx for the PR; however, the check is correct.

The reason the check is written the way it is is so that the plugin will become a no-op when it's functionality is merged in WP core. In other words, in WP 5.5.0 there will be a function named wp_is_plugins_auto_update_enabled() already defined, so this plugin will not do the include and the functionality is core will take over.

tylerdigital commented 4 years ago

Oh I see, thank you for the clarification (sorry for the invalid ticket)

pbiron commented 4 years ago

No problem, it was an understandable mistake. The inline comment on the test could be more explanatory :-)