search

WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

Third-party Plugins #104

Open ronalfy opened 4 years ago

ronalfy commented 4 years ago

I am representing Easy Updates Manager with these questions:

  1. Since the merge proposal has already been submitted and a ticket created, how reliable are the code base, functions, option names, filters, and what not? Are they going to change once merged into core? We're trying to decide how to be as compatible as possible with the proposed changes.

  2. Are you open to suggestions on hooks/filters should we proceed with the integration?

pbiron commented 4 years ago

I am representing Easy Updates Manager with these questions:

Thanx for the questions.

  1. Since the merge proposal has already been submitted and a ticket created, how reliable are the code base, functions, option names, filters, and what not? Are they going to change once merged into core? We're trying to decide how to be as compatible as possible with the proposed changes.

I'm working on the patch for the core merge right now.

In general, the code in this feature plugin is close to what will be in core after the merge. Of course, most of the actual functions in the plugin won't exist in core, their functionality will be incorporated into methods WP_Plugins_List_Table and WP_MS_Themes_List_Table (and the "driver" files for the screens on which the list tables are displayed), rather than being callbacks for the hooks that those list tables provide.

While I haven't talked this over with @audrasjb, I will be proposing that the 2 site options be renamed in core. That is, instead of wp_auto_update_plugins and wp_auto_update_themes they would just be auto_update_plugins and auto_update_themes.

I think all the filters will remain unchanged once merged into core.

At least one person has expressed concerns about all of the constants, and doesn't think they should be used in core. We will be discussing that during the meeting tomorrow (@ 1800 UTC).

Plus, I just opened a PR that is a rewrite of the Ajax stuff (#103). That changes the markup displayed in the Automatic Updates column (and on the non-multisite themes screen).

  1. Are you open to suggestions on hooks/filters should we proceed with the integration?

Sure.

We will have to do at least one more release of this plugin before producing the patch for the core merge (to account for some of the things mentioned above).

Also, even after the original merge into core is done, there is always the possibility of further changes before 5.5.0 is release (design, code base, and features). Again, haven't discussed this with @audrasjb, I fully expected that an changes in core before 5.5.0 is released will be backported to this plugin and we'll release subsequent versions so that those running some version of 5.4.x will be able to continue testing things.

Hope you will be able to make the meeting tomorrow.