Closed audrasjb closed 4 years ago
Ok, so let's say that we wait for #103 to be merged and then I refreshes this PR 🙂
Ok, so let's say that we wait for #103 to be merged and then I refreshes this PR 🙂
That's probably going to cause similar git conflicts. So, maybe close this PR, what until #103 is merged and then open a new PR?
Right, would be easier to merge 103 then refresh and merge these changes.
As far as I see all the changes here look good.
@pbiron I updated the PR accordingly, could you please take a look?
In this PR:
aria-label
atttributes Fixes #106 and partially #94 (see this comment)automatic updates
withauto-updates
for better consistency Fixes #108I kept some of the
automatic updates
strings, when they appear in error messages.