WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

I18n - Unnecessary concatenation #116

Closed pedro-mendonca closed 4 years ago

pedro-mendonca commented 4 years ago

Possible issue with genre in some languages https://github.com/WordPress/wp-autoupdates/blob/master/functions.php#L1332

The current code have 3 strings:

This could easily be simplified with just two, with no possible genre issues for the concatenated parts of speach ( Theme/Plugin)

The above case can raise more issues, being "Theme" or "Plugin" single uppercase words, this could easily mess around other future strings. In this particular case make sense that it's uppercase for english, but for a language that adds an article before the %s, the uppercase won't make sense, but translators probably shold respect it. Too many i18n potential issues, that should be avoided with two simple strings, no variables.

The same happens here: https://github.com/WordPress/wp-autoupdates/blob/master/functions.php#L1343

Issues could be avoided and strings count reduced:


See #107