search

WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
57 stars 18 forks source link

Implement Prettier #118

Closed whyisjake closed 4 years ago

whyisjake commented 4 years ago

This is a fork of the work that @ntwb did in #111. I extended a few things and then brought the changes over from master.

ntwb commented 4 years ago

Looking good, this is what I'm seeing:

> wp-scripts lint-js

/Users/netweb/Code/WordPress/wp-autoupdates/js/wp-autoupdates.js
   37:5   error  'data' is never reassigned. Use 'const' instead    prefer-const
   45:13  error  'ajaxurl' is not defined                           no-undef
  117:23  error  'response' is defined but never used               no-unused-vars
  143:8   error  'plugin' is never reassigned. Use 'const' instead  prefer-const
  152:6   error  'jQuery' is not defined                            no-undef

✖ 5 problems (5 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
whyisjake commented 4 years ago

@ntwb, added a few updates, coming back clean now.

ntwb commented 4 years ago

Thanks @whyisjake 👍

whyisjake commented 4 years ago

Ready for review @ntwb / @pbiron / @audrasjb