search

WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

Titlecase vs. Uppercase #120

Open whyisjake opened 4 years ago

whyisjake commented 4 years ago

I think we are being pretty deliberate, but I think we might want to change a few things to enforce uppercase (@audrasjb commented about how all Americans want to capitalize everything...)

Screen Shot 2020-05-07 at 10 36 21 AM

👆This does seem to follow titlecase, but I think we should be using uppercase for these string. Looks better in the prominent area of the page.

Screen Shot 2020-05-07 at 10 36 28 AM

☝️Kinda feel the same here. This isn't a sentence, I almost wonder if this should be a button or dropdown to ensure that people know this is a UI element. The JS actions here can be almost invisible, so ensuring that this looks and behaves like a button might be in our best interest. Toggle? Radio? Checkbox???

Screen Shot 2020-05-07 at 10 39 53 AM

☝️ Bulk Actions is the headline for the dropdown, but I think we should follow and make that string uppercased too.

audrasjb commented 4 years ago

I'd personally use sentence case, but… why not. In any case, we need to fix this inconsistency :)

whyisjake commented 4 years ago

I wonder if we should use this UI element for the table view.

Screen Shot 2020-05-07 at 11 26 44 AM
whyisjake commented 4 years ago

☝️could be auto-updates disabled

👇 could be auto-udpates enabled

Screen Shot 2020-05-07 at 11 32 15 AM
pbiron commented 4 years ago

With regard to buttons vs links, I don't know if the same reasoning should apply here (tho I suspect it would), but prior to 5.4 the Privacy tools (which are also list tables) had buttons in their "Next Steps" column. Those were changed to links (visually) in 5.4 on recommendation from the design team.

See trac ticket #49323.

pbiron commented 4 years ago

@audrasjb I just did some checking and if using <button class="button-link"> would be better for a11y (which is what the Privacy tools mentioned above use) we can switch to that with only minor mods to wp_autoupdates_plugins_enabler() and wp_autoupdates_themes_enabler() (for non JS-enabled browsers) and the click handler in the JS for Ajax.

It is pretty late in the game to be making a change like that, but if it is better for a11y, I suspect it will also come up on the core merge patch. So, we might as well do it in the plugin as well.

whyisjake commented 4 years ago

Yeah, I don't think this should be a blocker for the core merge, but should at least be brought up and get design-feedback on. Thanks for the links @pbiron. Great context.

wittwitsan commented 4 years ago

There is an audit /wp-admin ticket #49616 about sentence-case UI elements.