search

WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

Enable/Disable links for Themes should not appear in the Theme Details modal on subsites in a multisite #67

Closed pbiron closed 4 years ago

pbiron commented 4 years ago

Why? Because when an admin user clicks on those links they get a wp_die() screen that says:

Please connect to your network admin to manage themes automatic updates.

If the link won't actually work, then it shouldn't be displayed. It is the same reasoning behind the entire Automatic updates not displaying on the Plugins screen of a subsite in a multisite.

pbiron commented 4 years ago

As an aside, about 10 days ago I mentioned the following in #slack

I just noticed that in a multisite, you are allowed to update themes (manually, not talking about auto-update) on the themes.php screen within a sub-site...whereas, for plugins you have to be on the network/plugins.php screen. Does anyone else thing that is a "bug" in core (i.e., shouldn't you have to be on network/themes.php)?

I think that's a bug in core because plugins can only be updated from the Network Admin > Plugins screen).

Does anyone think I should open a trac ticket for that?

pbiron commented 4 years ago

Thanx @JJJ, will do.

pbiron commented 4 years ago

The core bug has been reported in Trac ticket #49831...but this issue is still a bug in this plugin :-)

rodolphebertozzo commented 4 years ago

For the milestone 0.5 ?