WordPress / wp-autoupdates

Feature plugin building a UI for opting-in to plugin, theme, and core auto-updates.
https://wordpress.org/plugins/wp-autoupdates/
GNU General Public License v2.0
56 stars 18 forks source link

Ensure disabling via AJAX doesn't result in errors of the link is clicked multiple times while processing is still happening. #96

Closed pbiron closed 4 years ago

pbiron commented 4 years ago

This addresses the 2nd part of #94.

It also fixes incorrect aria-labels in the AJAX results and harmonizes wp_autoupdates_enable_auto_updates() and wp_autoupdates_disable_auto_updates() so their code structure more closely aligns with one another.

azaozz commented 4 years ago

Right, the patch fixes the multiple click/multiple returns bug but the code there generally can probably be better. Will add inline comments.

azaozz commented 4 years ago

Another UI thing that may need considering/fixing: Screen Shot 2020-05-01 at 13 28 31

Seems a lot of repetition, also some inconsistency?

Edit: ugh, this is in the wrong place, sorry. Moving to https://github.com/WordPress/wp-autoupdates/issues/94.