Issue with JQuery 3.5.1

dreed12 commented 4 years ago

I use a Kadence theme and on a page that has been built with the SiteOrgin Layout plugin, I cannot edit the page when JQuery is set to v3.5.1. When I try to load the page, it shows "The editor has encountered an unexpected error." and the Associated error refers to YoastSEO:

This happens with JQuery Migrate enabled or disabled, and also the UI version doesn't matter.

If I just disable JQuery Migrate, the page behaves as expected so seems to be a conflict with the JQuery version.

Hope this helps Dom

azaozz commented 4 years ago

Thanks for the report. Yes, sounds like a possible jQuery compatibility issue in either SiteOrigin's plugin (assuming https://github.com/siteorigin/siteorigin-panels) or YoastSEO (https://github.com/Yoast/wordpress-seo).

dreed12 commented 4 years ago

Hi, just to confirm, you’re right about which SiteOrgin plugin I mean.

Thanks Dom On 17 Jul 2020, 22:00 +0100, Andrew Ozz notifications@github.com, wrote:

Thanks for the report. Yes, sounds like a possible jQuery compatibility issue in either SiteOrigin's plugin (assuming https://github.com/siteorigin/siteorigin-panels) or YoastSEO (https://github.com/Yoast/wordpress-seo). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

isaumya commented 4 years ago

Hi, When I enabled the latest jQuery, disabled jquery migrate, the following errors are being thrown by jQuery 3.5.1

Uncaught TypeError: e.indexOf is not a function
    at S.fn.init.S.fn.load (jquery-3.5.1.min.js:2)
    at HTMLDocument.document.onreadystatechange (autoptimize_single_18947a7e5ef98a1432f72ba5da53da42.js:14)
    at HTMLDocument.t.<computed> (VM3548 rocket-loader.min.js:1)
    at l (VM3548 rocket-loader.min.js:1)
    at t.simulateStateAfterDeferScriptsActivation (VM3548 rocket-loader.min.js:1)
    at Object.callback (VM3548 rocket-loader.min.js:1)
    at t.run (VM3548 rocket-loader.min.js:1)
    at VM3548 rocket-loader.min.js:1
    at HTMLScriptElement.<anonymous> (VM3548 rocket-loader.min.js:1)

Which leads to breaking of other things like owl carousal

Uncaught TypeError: e.indexOf is not a function
    at S.fn.init.S.fn.load (jquery-3.5.1.min.js:2)
    at owl.carousel.min.js:1

Uncaught TypeError: a(...).find(...).andSelf is not a function
    at c.<anonymous> (owl.carousel.min.js:1)
    at HTMLDivElement.i (jquery-3.5.1.min.js:2)
    at HTMLDivElement.dispatch (jquery-3.5.1.min.js:2)
    at HTMLDivElement.v.handle (jquery-3.5.1.min.js:2)
    at Object.trigger (jquery-3.5.1.min.js:2)
    at HTMLDivElement.<anonymous> (jquery-3.5.1.min.js:2)
    at Function.each (jquery-3.5.1.min.js:2)
    at S.fn.init.each (jquery-3.5.1.min.js:2)
    at S.fn.init.trigger (jquery-3.5.1.min.js:2)
    at e.trigger (owl.carousel.min.js:1)

But enabling jQuery migrate with jQuery 3.5.1 stops giving this e.indexOf issue.

Please note that the issue mentioned above is happening regardless of whether I am using jQuery UI latest or default.

stefanos82 commented 4 years ago

@azaozz I have reported a jQuery UI bug that affects WooCommerce's Quick Edit mechanism; please read more at https://github.com/woocommerce/woocommerce/issues/27340

azaozz commented 4 years ago

Thanks @isaumya and @stefanos82 for the reports.

isaumya commented 4 years ago

I'm also getting issues with wpColorPickerL10n and colour picker is not working. Here is an error report:

Uncaught ReferenceError: wpColorPickerL10n is not defined

I'm using jQuery 3.5.1 with jQuery Migrate 3.3.0

WordPress / wp-jquery-update-test

Issue with JQuery 3.5.1 #3