Add filtering for each tag after adding the loading attribute

WordPress / wp-lazy-loading

Feature plugin for testing and experimenting with the "loading" HTML attribute.

https://wordpress.org/plugins/wp-lazy-loading/

GNU General Public License v2.0

69 stars 21 forks source link

Add filtering for each tag after adding the loading attribute #10

Closed azaozz closed 4 years ago

azaozz commented 4 years ago

Based on https://github.com/WordPress/wp-lazy-loading/pull/7.

Add some checks before running the regex in wp_add_lazy_load_attributes().
Filter each tag after adding the attribute.

See: https://github.com/WordPress/wp-lazy-loading/pull/4.

azaozz commented 4 years ago

This brings some of the changes from https://github.com/WordPress/wp-lazy-loading/pull/9, but "scopes" them only for adding of the "loading" attribute to img tags and eventually to iframes.

spacedmonkey commented 4 years ago

Why was this merged? We were still discussing the propertiy here. https://github.com/WordPress/wp-lazy-loading/pull/10/files#r371407221

felixarntz commented 4 years ago

@spacedmonkey We'd like to release a first version of the plugin today, and this looked good to go for that. Things will continue to be iterated on, we can also continue discussing the hook priority (as I see you already opened #12 for that 👍).