WordPress / wp-movies-demo

Demo of the Interactivity API
https://wpmovies.dev
GNU General Public License v2.0
195 stars 42 forks source link

Cleaning up the repo and removing the runtime #21

Closed SantosGuillamot closed 1 year ago

SantosGuillamot commented 1 year ago

This PR aims to clean up the movies repo and remove the code related to the runtime, as we will require the BHE plugin, which should be the one requiring it. As it is right now, it is relying on the build-to-globals branch, as it is exposing the functions needed by the blocks in the window.

Some of the things covered here:

SantosGuillamot commented 1 year ago

I've tried adding the BHE repo to wp-env, but it returns some error. Maybe it's better to wait until we create a downloadable ZIP file, similar to this PR, so we can link directly there.

SantosGuillamot commented 1 year ago

I've tried adding the BHE repo to wp-env, but it returns some error. Maybe it's better to wait until we create a downloadable ZIP file, similar to https://github.com/c4rl0sbr4v0/wp-movies-demo/pull/20, so we can link directly there.

I solved this issue in the release-action PR, which is intended to be merged in this branch.

michalczaplinski commented 1 year ago

I didn't get to review it properly today, sorry. I ll get round to it on Monday 🙂

SantosGuillamot commented 1 year ago

I thought we could add a disclaimer to indicate that import store with a global is just a temporary solution.

Totally makes sense 🙂 I've just committed the suggestions.

michalczaplinski commented 1 year ago

OK, I've pushed a few small improvements and I think we can merge this and https://github.com/c4rl0sbr4v0/wp-movies-demo/pull/20 👍👍👍