Closed SantosGuillamot closed 1 year ago
I've tried adding the BHE repo to wp-env
, but it returns some error. Maybe it's better to wait until we create a downloadable ZIP file, similar to this PR, so we can link directly there.
I've tried adding the BHE repo to wp-env, but it returns some error. Maybe it's better to wait until we create a downloadable ZIP file, similar to https://github.com/c4rl0sbr4v0/wp-movies-demo/pull/20, so we can link directly there.
I solved this issue in the release-action PR, which is intended to be merged in this branch.
I didn't get to review it properly today, sorry. I ll get round to it on Monday 🙂
I thought we could add a disclaimer to indicate that import store with a global is just a temporary solution.
Totally makes sense 🙂 I've just committed the suggestions.
OK, I've pushed a few small improvements and I think we can merge this and https://github.com/c4rl0sbr4v0/wp-movies-demo/pull/20 👍👍👍
This PR aims to clean up the movies repo and remove the code related to the runtime, as we will require the BHE plugin, which should be the one requiring it. As it is right now, it is relying on the
build-to-globals
branch, as it is exposing the functions needed by the blocks in thewindow
.Some of the things covered here:
runtime
and the client-side navigation files, as well as the settings. This should be handled by the other plugin.npm
dependencies.store
andnavigate
functions to read fromwindow.__experimentalInteractivity
.content-creator
folder, as we are generating the content in a different way.state
and theselectors
to the SSR files.