WordPress / wp-plugin-dependencies

WordPress Feature Project: Plugin Dependencies
https://make.wordpress.org/core/2022/02/24/feature-project-plugin-dependencies/
MIT License
69 stars 9 forks source link

Change deactivated notice #13

Closed morehawes closed 2 years ago

morehawes commented 2 years ago

This admin notice better reflects what has occurred: some plugins had to be deactivated because their dependencies are now unmet.

The reason being that their dependencies were deleted, which WordPress lists as separate admin notices below.

afragen commented 2 years ago

But it's not necessarily true that the dependency was deleted. What is true is that the dependencies are unmet and the plugin was deactivated.

This might also be more than one plugin from a bulk activation. Also, if using WP-CLI it's likely possible to activate and then the next page load would deactivate. I haven't tested that, but I can visualize it.

morehawes commented 2 years ago

But it's not necessarily true that the dependency was deleted. What is true is that the dependencies are unmet and the plugin was deactivated.

Understood. It's currently not possible to attempt to activate a plugin that has unmet dependencies, which is what the current message states:

Screenshot 2022-06-07 at 1 19 52 PM

My suggestion is to simply state that plugins were deactivated:

Screenshot 2022-06-07 at 1 25 43 PM

I thought the wording works for multiple plugins, but also open to suggestions.

I also realise this is quite a minor thing. I'm new around here so do let me know if PRs are not the right format for this :)

afragen commented 2 years ago

Fixed in https://github.com/WordPress/wp-plugin-dependencies/commit/48ab82f109b63b4b561e2a96243008b5003bd5f3