WordPress / wporg-developer

WordPress.org Developer theme
https://developer.wordpress.org/
61 stars 24 forks source link

Path and Link Broken in Theme Security Handbook #509

Open marcarmengou opened 6 months ago

marcarmengou commented 6 months ago

Moving this issue https://github.com/WordPress/wporg-main-2022/issues/435 here as suggested by @pkevan

Original issue:

In the new WordPress.org translation strings I found a broken link to a section of the Theme Handbook that does not yet exist.

https://github.com/WordPress/wporg-main-2022/blob/618fd76e47510e15fa0184ccd03d52562c1814f0/source/wp-content/themes/wporg-main-2022/patterns/about-security.php#L40

From the complete link address https://developer.wordpress.org/themes/theme-security/theme-security-issues/ the upper section does not exist either /theme-security/

pkevan commented 6 months ago

@marcarmengou the page should now work - can you let me know if it doesn't?

marcarmengou commented 6 months ago

Thanks @pkevan. The page is now publicly visible.

On the other hand I see that https://developer.wordpress.org/themes/theme-security/ has a 301 redirect to https://developer.wordpress.org/themes/theme-security/theme-security-issues/ If the redirect is only temporary, perhaps you should use a 302.

Just to confirm if this is correct for you. The only way to access the resource https://developer.wordpress.org/themes/theme-security/theme-security-issues/ is through the link on this page https://wordpress.org/about/security/, since the top page https://developer.wordpress.org/themes/theme-security/ does not exist or is not publicly visible in https://developer.wordpress.org/themes/

carolinan commented 3 months ago

Issues related to the Theme developer handbook can be opened in the documentation issue tracker and labeled with themes: https://github.com/WordPress/Documentation-Issue-Tracker

Tickets in this repository, wporg-developer, is not monitored by members of the Themes team that manages the content of this handbook, and the team would need to be notified.

This page https://developer.wordpress.org/themes/theme-security/theme-security-issues/ is not intended to be published in the Theme developer handbook. Its content is not related to theme development but to themes in the theme directory.

The existing page related to security is https://developer.wordpress.org/themes/advanced-topics/security/

This page https://developer.wordpress.org/themes/theme-security/ is intended to help users who arrive at this page from links that have not been updated, instead of arriving on a 404. It is not intended to be redirected to https://developer.wordpress.org/themes/theme-security/theme-security-issues/

It is supposed to have information about contents being moved to https://developer.wordpress.org/apis/security/