WordPress / wporg-documentation-2022

15 stars 6 forks source link

Fix the position of the Table of Contents #97

Closed adamwoodnz closed 3 months ago

adamwoodnz commented 3 months ago

This PR updates the single page template to use the 3 column layout from the parent theme. This brings alignment with the single pages on Developer Resources, and fixes the incorrect positioning resulting from https://github.com/WordPress/gutenberg/pull/60347. In implementing this layout I've also updated the post title text styles, and moved the search bar to the new position shown in the designs.

Depends on https://github.com/WordPress/wporg-mu-plugins/pull/624 and https://github.com/WordPress/wporg-parent-2021/pull/140 Closes https://github.com/WordPress/wporg-documentation-2022/issues/96 Closes https://github.com/WordPress/wporg-documentation-2022/issues/95

Screenshots

Desktop

Before After
wordpress org_documentation_article_search-engine-optimization_(Desktop) wordpress org_documentation_article_search-engine-optimization_(Desktop) (1)

How to test the changes in this Pull Request:

  1. Easiest to test in sandbox along with the sibling PR for Developer Resources
  2. Check the position of the table of content on page load and when scrolling. Check that the height of the sidebar reduces when coming in contact with the tall footer. Check responsive behaviour.
  3. Check the search bar position across the site