WordPress / wporg-gutenberg

The theme for https://wordpress.org/gutenberg/
https://wordpress.org/gutenberg/
10 stars 5 forks source link

There are design discrepancies. #31

Closed StevenDufresne closed 2 years ago

StevenDufresne commented 2 years ago

I tried to use Gutenberg & theme.json updates to show Gutenberg in all its glory! As a result, there were things that we couldn't do. We could patch them with some custom CSS or leave them as is. I'm not sure what to do so I opened this ticket.

In addition, you may see some slight variations when you look at the page logged in and logged out. The editor seems to append extra classes in different ways between the 2 contexts. I designed the page to look the best when logged out. I think trying to make them look identical is probably a waste of time.

Lastly, since we are technically always viewing the block editor, we are bound to the responsivity in that context. Therefore, we have to rely on empty columns and full-width components (buttons mostly) to get the layouts to work. You'll notice this most obviously with the buttons.

Here are some of the more visible differences:

Design Implementation
beafialho commented 2 years ago

Thanks @StevenDufresne!

This Instead of this
Captura de ecrã 2022-04-28, às 10 36 45 Captura de ecrã 2022-04-28, às 10 36 13

This was different in the mockup and you reproduced it accurately, but now looking at it, it made more sense to me this way.

StevenDufresne commented 2 years ago

@beafialho I'll try to get the image in the right order like that in Gutenberg but we'll probably need custom CSS, the cover/image controls aren't flexible enough to play with order and absolute positioning.

beafialho commented 2 years ago

@StevenDufresne I was referring to the width of the buttons. I'd say it's ok if the order of the image can't be achieved though.

StevenDufresne commented 2 years ago

This was fixed along with #35.