search

WordPress / wporg-gutenberg

The theme for https://wordpress.org/gutenberg/
https://wordpress.org/gutenberg/
10 stars 5 forks source link

Remove editor experience when using handheld devices #47

Closed renintw closed 2 years ago

renintw commented 2 years ago

Fixes #46

~The logic can also be placed in the following block to avoid running unnecessary logic, but we have to enqueue the required styles. https://github.com/WordPress/wporg-gutenberg/blob/4690151bf3bce5cf35b45a07e2c80b1de0522a9e/source/wp-content/themes/wporg-gutenberg/functions.php#L478-L487~

Screencast

https://user-images.githubusercontent.com/18050944/188007700-4b35e296-27ac-4d8d-84f6-167f8a9d45a4.mov

The font-weight of the heading and the border styles of the button are still off, that's probably because they're no longer in the editor, so the class name editor-styles-wrapper doesn't exist anymore. And the button style in the sandbox is different from the one in local env (sandbox has squared black border)

Do we want the styles to be exactly the same as the original ones?

StevenDufresne commented 2 years ago

Right, it's missing all the editor-styles-wrapper classes. We need to figure out how to load what is returned from get_block_editor_theme_styles.

tellyworth commented 2 years ago

The mobile version might need some slight variations in content. That needn't necessarily be fixed in this PR, but it might be worth opening a new issue after fixing this one to decide what content changes are needed. (Perhaps the "Click around to explore" text)

renintw commented 2 years ago

Updated screencast (Styles fixed)

https://user-images.githubusercontent.com/18050944/188504893-e98f9097-45cd-40bb-812f-431118398492.mp4

TODO

  1. Fix the shaking when loading the page.
  2. Adjust content to make it conform to the mobile context.
StevenDufresne commented 2 years ago

Apart from the styles, how do you think we can deal with this copy that appears on the desktop view:

"This page was built with blocks — pieces of content that you can move around. Click around to explore them."

renintw commented 2 years ago

Apart from the styles, how do you think we can deal with this copy that appears on the desktop view: "This page was built with blocks — pieces of content that you can move around. Click around to explore them."

I'm thinking of only changing Click around to explore them. Maybe append something like (only available on Desktop) to it? Or Explore the whole features on Desktop.

StevenDufresne commented 2 years ago

Apart from the styles, how do you think we can deal with this copy that appears on the desktop view: "This page was built with blocks — pieces of content that you can move around. Click around to explore them."

I'm thinking of only changing Click around to explore them. Maybe append something like (only available on Desktop) to it? Or Explore the whole features on Desktop.

I think just removing Click around to explore them. is good enough for now. We can ask for feedback later.