WordPress / wporg-main-2022

A block-based child theme for WordPress.org, plus local environment
65 stars 26 forks source link

Possible double strings #285

Closed NekoJonez closed 1 year ago

NekoJonez commented 1 year ago

While translating the newest strings for WP.org, I noticed that sometimes the cosistency tool was showing two strings... And I'm under the impression that we have some double strings...

These are two I found:

https://translate.wordpress.org/projects/meta/wordpress-org/nl-be/default/?filters[status]=either&filters[original_id]=5848165&filters[translation_id]=105619990 https://translate.wordpress.org/projects/meta/wordpress-org/nl-be/default/?filters[status]=either&filters[original_id]=16047146&filters[translation_id]=105619549


https://translate.wordpress.org/projects/meta/wordpress-org/nl-be/default/?filters[status]=either&filters[original_id]=5848112&filters[translation_id]=105619863 https://translate.wordpress.org/projects/meta/wordpress-org/nl-be/default/?filters[status]=either&filters[original_id]=16047117&filters[translation_id]=105619858

Could this be looked at, since now it has the chance that it destroys consistency. Or if they are different... Maybe add a translator note why they are different. Eg, one is a heading and the other is in text.

tobifjellner commented 1 year ago

GlotPress (and Gettext) use the source string as index key, so if there are several strings, then there is a difference between them. In the strings you showed here, the source strings have different capitalization. Perhaps the American Camel Case is used for titles, and that could be useful to mention.

(And while we're at it, please don't try to recreate American Camel Case via CSS, because almost all our target languages handle this differently than US English.)

ryelle commented 1 year ago

Just to make it easier to compare, I pulled your examples out into a table here. The links go to the source code.

Old theme content New theme content
Version Numbering and Security Releases Version numbering and security releases
WordPress.org Theme and Plugin Repositories WordPress.org theme and plugin repositories

The first column is from the wporg-main theme, which is only used on the rosetta sites right now and will stop being used when the new theme is rolled out. The first column could be considered "deprecated."

I think the change to sentence case was an intentional style change by the marketing folks who worked on this, is that right @thetinyl @eidolonnight ?

eidolonnight commented 1 year ago

the change to sentence case was an intentional style change by the marketing folks

Correct! The WordPress Brand Writing Style Guide notes the following:

Headlines and subheadlines are sentence case, without final punctuation. Sentence case can help make headlines easier to read (or scan).

Just keep in mind that there is an exception for News.

StevenDufresne commented 1 year ago

@NekoJonez Does that suffice? Is there anything left to action on this ticket.

NekoJonez commented 1 year ago

@NekoJonez Does that suffice? Is there anything left to action on this ticket.

I would add comments where what is used. And also, Tobi's comment is important. In my locale, American Camel case is frowned upon

ryelle commented 1 year ago

We're not using CSS to force any capitalization, so that shouldn't be an issue.

I would add comments where what is used.

The new strings should be the only ones used going forward. The old ones will still exist since the old wporg-main theme exists, but it will stop being used once the redesign is fully launched.

NekoJonez commented 1 year ago

I wanted to post a funny gif like "we are done here" but couldnt find one :P Thanks everyone (Since this is an issue that will solve itself through time)

ryelle commented 1 year ago

Thanks!