search

WordPress / wporg-main-2022

A block-based child theme for WordPress.org, plus local environment
65 stars 26 forks source link

Homepage: Dream it section overflows in some languages #306

Closed javiercasares closed 7 months ago

javiercasares commented 1 year ago

Origin: https://wordpress.slack.com/archives/C02S78ZAL/p1691584951569959

At the new homepage if the "Dream it, build it" is longer than 250px, it breaks.

ryelle commented 1 year ago

Pulling out the screenshots & comment from slack:

We are testing some parts of the new design of rosetta sites that we can see in https://wordpress.org/ with our language (catalan) and have found a problem with the section “Dream it, build it”. This section has a max-width of 520px and the h2 has a font-size of 120px. With this sizes when the text is translated to something a litle bit longer, the text does not fit and overflows lines. Here are two images to see the problem. We can resolve this tweaking the css in locale, but then, any update would make us lose the changes. So, I ask you if you can think on decrease the h2 size and/or increase the max-widht a little bit, to fit more languages?

English Catalan
Blog_Tool__Publishing_Platform__and_CMS_–_WordPress_org Cursor_y_Blog_Tool__Publishing_Platform__and_CMS_–_WordPress_org
marcarmengou commented 8 months ago

We have wp.org translated since we created this issue, but we can't activate the new theme because of this problem.

ryelle commented 8 months ago

I have a PR here to adjust the heading font sizes for different languages, here's how Catalan would look. What do you think, @marcarmengou ?

Before After
home-ca-before home-ca-after
javiercasares commented 8 months ago

Great! :) LGTM

marcarmengou commented 8 months ago

Great! That solves the main problem with the CTA. The fact that you can request some adjustment, if needed, is also sound good. Thanks :)