search

WordPress / wporg-main-2022

A block-based child theme for WordPress.org, plus local environment
68 stars 26 forks source link

Remove "Edit site" from front end admin bar #390

Closed ryelle closed 6 months ago

ryelle commented 7 months ago

Content should be managed through the page editor, not the site editor. The sync script pulls from page content. If the Site Editor is used, it creates a new custom template & overrides the theme template, breaking the connection to translations/future content updates.

To prevent confusion, I think we should remove the "Edit site" option from the frontend, and only let users hit "Edit page" (could also remove "Customize", I don't think anything is managed there anymore).

Screenshot 2024-02-21 at 4 45 36 PM

This might also prevent Rosetta sites from attempting to "translate" the page content via the site editor.

I'm on the fence about removing Appearance > Editor from wp-admin, are there any legit reasons for needing to use the site editor?

dd32 commented 7 months ago

I'm on the fence about removing Appearance > Editor from wp-admin, are there any legit reasons for needing to use the site editor?

I think it would make sense to remove it for now, and add it back if it turns out to be needed.

dd32 commented 6 months ago

This also appears to be a problem on Rosetta sites.

Simply removing the links to the Site Editor likely isn't enough, ideally we should prevent it's use entirely.

fr.wordpress.org had customized the front page through the site editor, which caused the translated templates not to be used.