WordPress / wporg-main-2022

A block-based child theme for WordPress.org, plus local environment
62 stars 22 forks source link

Rosetta sites: Heading line height too small for cn.w.org #424

Closed ryelle closed 2 months ago

ryelle commented 3 months ago

Hello, this is the zh_CN polyglot team. We switched to new theme a few days ago. Currently, we mainly find that the spacing of multi-line titles is too small, for example:

https://cn.wordpress.org/about/: image

https://wordpress.org/about/: image

https://cn.wordpress.org/download/releases/6-5/: image

https://wordpress.org/download/releases/6-5/: image

@ryelle Can you help optimize this, just adjust it like japanese?

Originally posted by @devhaozi in https://github.com/WordPress/wporg-main-2022/issues/266#issuecomment-2039468977

ryelle commented 3 months ago

@devhaozi What line height works best?

line-height: 1 line-height: 1.1 line-height: 1.2
about-10 about-11 about-12
release-10 release-11 release-12

Are the line heights on other headings okay? For example, this?

Screenshot 2024-04-05 at 3 28 53 PM
devhaozi commented 3 months ago

What line height works best?

1.2 is better, and then the word spacing needs to be increased a little bit, like the last image.

Are the line heights on other headings okay?

Yes, they looks okay.

nukaga commented 3 months ago

Hello. We are just in the process of adjusting the design of the About page in Japanese as well. I'm thinking 1.2 line spacing is good for Japanese as well.

About

ping @miminari

ryelle commented 2 months ago

I've updated this to use line-height: 1.2 whenever the line height is <1, and the default letter spacing whenever letter spacing is negative, for both cn.wordpress.org and ja.wordpress.org.