WordPress / wporg-main-2022

A block-based child theme for WordPress.org, plus local environment
62 stars 22 forks source link

Content updates from Page Editor #446

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

The content has changed in the Page Editor. Please review, merge, and deploy.

fcoveram commented 1 month ago

I like how simple this design is. A few thoughts that are not blockers but could be good to try.

On 1600 and800`, center the text and icon and reduce the spacing between them to be 8px.

Homepage banner on 1600px and 800px viewport

On 480 and 360, align the text on the left and chevron icon on the right with a padding of 23px on the sides.

Homepage banner on 480px and 360px viewport

This spacing aligns vertically the menu and chevron icons.

Wireframe of homepage on the banner area with rules

Before any implementation, could be good to have @jasmussen and @marko-srb eyes on my suggestions.

jasmussen commented 1 month ago

Good feedback. I'm working on addressing it. So far I've removed the alt text, and adjusted the right-padding so the chevron lines up with the menu item on mobile:

Screenshot 2024-06-03 at 18 56 31

Screenshot 2024-06-03 at 18 56 47

Screenshot 2024-06-03 at 18 56 56

Screenshot 2024-06-03 at 18 57 03

I'm looking to get closer to your mockup for the whitespace on desktop, but it's not clear how close I can get.

jasmussen commented 1 month ago

Here's the current state:

Screenshot 2024-06-03 at 19 00 59 Screenshot 2024-06-03 at 19 00 52 Screenshot 2024-06-03 at 19 00 39 Screenshot 2024-06-03 at 19 00 31 Screenshot 2024-06-03 at 19 00 21

ryelle commented 1 month ago

I've cleaned this up a little— switched the alignment for desktop/mobile so it matches @fcoveram's proposal, and I also switch the vertical alignment to center so the chevron is centered when the text wraps.

1600 800 480 360
home-banner-1600 home-banner-800 home-banner-480 home-banner-360

I'll merge this now since we wanted it deployed today, and if there are any issues remaining we can follow up in another PR/update.

jasmussen commented 1 month ago

Thank you 🙏

fcoveram commented 1 month ago

It looks great 🌟 Thanks @ryelle

daveloodts commented 3 weeks ago

Hi, with all 100% respect for Matt Mullenweg, but an idolization of 1 person in the biggest WordPress community conference isn't that much community-driven. What about other speakers? What about 14 june?

A better line would be: "Discover WordCamp Europe online: watch the live streams on 14 and 15 june".

On our nl-be rosetta site, i already took the initiative by translating it to promote the "whole event", not just the talk of Matt Mullenweg.