search

WordPress / wporg-make

The repo for the Make.WordPress.org theme. wporg-make-2024
0 stars 0 forks source link

SVG icons for teams #16

Open adamwoodnz opened 1 month ago

adamwoodnz commented 1 month ago

Replace team dashicons with SVGs to fix alignment issues and improve aesthetics.

I see some misalignments that seemed caused by the font and its x baseline. Here are some examples.

Section Header
Design Design header on Make page
Meta Meta header on Make page
Sustainability Sustainability header on Make page

Originally posted by @fcoveram in #2

Huh, that's a curious one indeed. It looks like there's nothing wrong with the CSS, but the globe in question is off-center in the Dashicons font itself.

Honestly it feels like an argument to update these icons to SVGs, and we can offer a consistent upgrade here to teams interested.

Originally posted by @jasmussen in #2

adamwoodnz commented 3 weeks ago

@WordPress/meta-design are we good to use the icons in the Figma?

Image

jasmussen commented 3 weeks ago

I want to say yes, but I think there's a larger question that has to be posted in a Make announcement, an offer for the individual teams to update the icon, because those icons are used in additional places including swag and otherwise. So for now I would keep using the existing dashicons here, and then postpone the offer of helping with icon redesigns to a later sprint. What do you think?