WordPress / wporg-mu-plugins

Development of the Global Header and other mu-plugins used on WordPress.org.
64 stars 29 forks source link

Overflow menu drops below header in Safari #194

Closed iandunn closed 2 years ago

iandunn commented 2 years ago

Reported at https://meta.trac.wordpress.org/ticket/6231

When we open any get involved method ( Like Core, Meta etc... ) in safari ( version 15.3) with 1440px and lower media query then menu is fall down. Please see screenshot for more information.

https://meta.trac.wordpress.org/raw-attachment/ticket/6231/wordpress.png

w.org currently has Gutenberg 12.8.1 pinned because of #193, so it's not caused by the same issue.

ryelle commented 2 years ago

Is this still an issue? I can't reproduce, but I've only tried in Safari 15.6.1

StevenDufresne commented 2 years ago

I see this on the homepage using: Safari Version 15.6.1 (17613.3.9.1.16)

Screen Shot 2022-09-13 at 1 06 14 PM

It's not exactly the same issue, but it's the same browser and component.

I see it happening on:

I don't see it happening on:

iandunn commented 2 years ago

Was the overflow menu removed when we switched to putting more things in submenus? If not, we can probably remove it since it's no longer being used. That might fix this issue.

ryelle commented 2 years ago

The overflow menu code is still there, it's just not triggered in the default state because the menu is small now. If you zoom text you can trigger it still, ex:

Screen Shot 2022-09-13 at 14 18 26

(obviously that does not look great by itself, but could be fixed as part of https://github.com/WordPress/wporg-mu-plugins/issues/248)

Tracked the issue back to this update — https://github.com/WordPress/wporg-mu-plugins/commit/53e9eeb4b3f3264d3b9577766919591224a62ced — it looks like the button has a margin which probably didn't matter when that button wasn't full-height, and some of the old themes have resets that remove it.

ryelle commented 2 years ago

Fixed that issue in b9ec0bcff21d797bd0ecb43f2f125b39aa7dfa93.

I think that is a different issue than the original report here, but we haven't been able to reproduce the original issue, so I'm inclined to close this.