WordPress / wporg-mu-plugins

Development of the Global Header and other mu-plugins used on WordPress.org.
63 stars 30 forks source link

Update Profile links to `View Profile` where applicable. #268

Open StevenDufresne opened 2 years ago

StevenDufresne commented 2 years ago

Originally reported in: https://meta.trac.wordpress.org/ticket/6478

When logged in to your WordPress account, user names in the Admin toolbar are linked to the edit profile page.

@jakariaistauk337 suggests that the first 2 username links should go to https://profiles.wordpress.org/{username}/. There is already an "Edit Profile" link that navigates appropriately.

dionysous commented 9 months ago

I didn't know what components were involved at first, so I had created this Meta-Trac ticket: https://meta.trac.wordpress.org/ticket/7462 I had the same idea as @StevenDufresne and think it's important that this is discussed.

Description

The admin bar dropdown for logged in users has redundancy in its navigation links. The intent of this ticket is to suggest an improvement to the user interface by altering one of the "Edit Profile" links to a "View Profile" link. This modification promises to improve the navigation experience by allowing users to swiftly access their public profile directly from the admin bar.

Current Interface

Alternative Proposed Interface Enhancement (v1)
wp org-admin-bar

Proposed Interface Enhancement

Challenges

Affected code

https://github.com/WordPress/wporg-mu-plugins/blob/a14fdd00695ba58dbc5b71a908780d9e7b92f537/mu-plugins/blocks/global-header-footer/admin-bar.php#L25-L29

Reference

dionysous commented 9 months ago

I would like to agree with @StevenDufresne and suggest changing the first 2 links:

Alternative Proposed Interface Enhancement (v2) wp org-admin-bar2

StevenDufresne commented 9 months ago

That does make sense to me, although I feel like that collapsed menu should display Howdy, {username} and keep the display name above view profile.

I'm basing that on the fact that the display name isn't a clear indication of what account your are accessing, so seeing it collapsed will be beneficial in the future for other wp.org functions (password resets, etc...) and when you arrive on your profile page, you immediately see your display name as the largest landmark next to your image which should match what you see in the dropdown, so there's a flow connection there as well.

It isn't a strong opinion though, i think either change is an improvement we could make for wp.org.

dionysous commented 9 months ago

I agree with you. It would just be important to me to show both the user name and the display name, as is currently the case. No matter how it is displayed, there is no question in my mind that we need View Profile linking and it would simplify navigation enormously.

Alternative Proposed Interface Enhancement (v3): wp org-admin-bar3

dd32 commented 7 months ago

These items are default core objects, not customised for WordPress.org at present.

This has changed slightly since this issue was opened, as it appears to have changed in core. https://github.com/WordPress/wordpress-develop/commit/eb33c60eaa0111bac7d98a84fd0cf067cd9c8571 https://github.com/WordPress/wordpress-develop/commit/44c41a52cf653a5136fc43c9f8305ec1f5d17b1f

There's no longer a separate Edit Profile link, that's merged with the Avatar.

See the PR below for a change that reflects the above suggestions.

dd32 commented 7 months ago

I feel like that collapsed menu should display Howdy, {username} and keep the display name above view profile.

I'm basing that on the fact that the display name isn't a clear indication of what account your are accessing, so seeing it collapsed will be beneficial in the future for other wp.org functions

In the same manner, the username might not be clear as to which account you're using for some users. I don't personally think we should be displaying the username here, as that's less human than the chosen display name IMHO..