Global header menus broken on Safari

WordPress / wporg-mu-plugins

Development of the Global Header and other mu-plugins used on WordPress.org.

52 stars 28 forks source link

Global header menus broken on Safari #632

Closed adamwoodnz closed 1 day ago

adamwoodnz commented 1 week ago

Reported in Slack

Since the latest update to wordpress.org, the menus Extend, Learn, Community, and About do not work on Safari on my MacBook Pro, Safari Version 17.5 (19618.2.12.11.6) & MacOS 14.5 (23F79). They work on Safari on my iPhone and iPad. No problems with Chrome and Firefox. Clicking on the menus doesn’t do anything. I need to type in https://wordpress.org/plugins/ for example to get to the plugins as clicking on Extend doesn’t do anything. The behavior is like those menu elements don’t get triggered by mouse clicks.

adamwoodnz commented 1 week ago

Reproduced locally with Gutenberg 18.6, was not an issue with 18.4.1.

Production is running 18.6

adamwoodnz commented 1 week ago

On clicking the submenu I can briefly see aria-expanded become true, before it immediately becomes false again, so the click event is firing, but something is likely wrong with the interactivity API state.

adamwoodnz commented 1 week ago

This change looks closely related

adamwoodnz commented 1 week ago

Pinned Gutenberg to 18.5.0 as a temp fix.

luisherranz commented 1 week ago

I've opened a PR with the fix:

https://github.com/WordPress/gutenberg/pull/62800

cbravobernal commented 1 week ago

I've released Gutenberg 18.6.1 with that fix.

adamwoodnz commented 1 week ago

18.6.1 has been deployed, looks good. Thanks all!

ryelle commented 1 day ago

If the GB update fixed this, can the issue be closed or is there something to follow up on?

adamwoodnz commented 1 day ago

Thanks for the reminder.