search

WordPress / wporg-mu-plugins

Development of the Global Header and other mu-plugins used on WordPress.org.
63 stars 29 forks source link

Learn is using the non-localized global header and footer #668

Open timse201 opened 3 hours ago

timse201 commented 3 hours ago

The links on global header menu are not localized, resulting in a poor user experience. Also the WordPress logo leads to the English site.

ryelle commented 3 hours ago

@timse201 Can you link to the site you're seeing this issue on? As on #667, I can't reproduce this. If I'm on a de.w.org site, for example https://de.wordpress.org/support/forum/installation/, the logo does link back to https://de.wordpress.org/.

timse201 commented 3 hours ago

Thanks for reply. I see these links on https://learn.wordpress.org/?locale=de_DE

ryelle commented 2 hours ago

Oh I see. Yes, it looks like that site is not using the correct header or footer. There are separate header & footer for the translated sites, and this is using the main English one instead.

The correct header on https://de.wordpress.org/support/forum/installation/

Image

The incorrect header on https://learn.wordpress.org/?locale=de_DE

Image

I'm going to close the other issue, since the root issue is the same for both header and footer.

timse201 commented 2 hours ago

ok, thanks

timse201 commented 1 hour ago

https://github.com/WordPress/learn/blob/trunk/wp-content/themes/pub/wporg-learn-2024/patterns/footer-content.php#L26

The links here (footer pattern for learn) are also not localized. Support forums and e.g. France has a translated documentation site.

ryelle commented 7 minutes ago

That's a separate issue, so I've created https://github.com/WordPress/Learn/issues/3027.