The "external link" icon should be the up-right arrow [↗︎]. It is already used this way in the global header menu. This icon is also used on the site as a decorative element, in those spaces it's used inline as a real character. This does not change anything there.
When the external-link class is used on a link element or container (eg, paragraph), it will add the icon as a background, so that it is not underlined (and to prevent screen readers from reading it, see #94).
Fixes #64 — We've standardized on the single arrow, for both decorative and external links.
Screenshots
Before
After
How to test the changes in this Pull Request:
Try using this branch with the showcase site:
View a single site page
Below the title, the URL should have the new arrow icon
Or without a separate site:
Create a new post/page, add a paragraph
Add the external-link class to the paragraph under Advanced
Add a link in the paragraph content, not pointing to wordpress.org.
The "external link" icon should be the up-right arrow [↗︎]. It is already used this way in the global header menu. This icon is also used on the site as a decorative element, in those spaces it's used inline as a real character. This does not change anything there.
When the
external-link
class is used on a link element or container (eg, paragraph), it will add the icon as a background, so that it is not underlined (and to prevent screen readers from reading it, see #94).Fixes #64 — We've standardized on the single arrow, for both decorative and external links.
Screenshots
How to test the changes in this Pull Request:
Try using this branch with the showcase site:
Or without a separate site:
external-link
class to the paragraph under Advanced