Remove the "secondary style" since the old search styles are deprecated now (correct?)
Adds a new style for "on dark" to handle the dark form
The focus states are a little different than the mockup, since the icon-button and input are separate, both focusable elements. There's a video at the end of this to show what I mean. Happy to iterate on this.
Mockup:
Screenshots
This will impact live sites using the parent theme, I think it's minimal (and expected, if this is the new search design that should be used). If that's not the case, we should figure out what cases use which search style.
Before
After
The following video shows the various focus, hover, and filled-in states. I know most of these variations won't be used, but on the chance they are, it shouldn't break.
jasmussen
commented
1 year ago
See https://github.com/WordPress/wporg-mu-plugins/issues/419 — the search field's styling is being updated in the next iteration of the redesign. This PR updates the current search styles to use this new design.
Mockup:
Screenshots
This will impact live sites using the parent theme, I think it's minimal (and expected, if this is the new search design that should be used). If that's not the case, we should figure out what cases use which search style.
The following video shows the various focus, hover, and filled-in states. I know most of these variations won't be used, but on the chance they are, it shouldn't break.
https://github.com/WordPress/wporg-parent-2021/assets/541093/462c97be-0f8b-4b30-bd41-16f75c9eb3b0
How to test the changes in this Pull Request: