WordPress / wporg-parent-2021

17 stars 10 forks source link

Update/spacing variables #106

Closed ryelle closed 11 months ago

ryelle commented 11 months ago

See #105 — The new designs use flexible spacing, the values are described in this codepen. The new spacing variables are almost identical to the existing values, with some minor changes.

I've also updated the docs for these values.

Before & After values at different sizes

At 450px wide | Name | Before | After | |--------------|--------|-------| | Small | 40px | 30px | | Medium | 40px | 40px | | Large | 25px | 20px | | 2X-Large | 80px | 80px | | 3X-Large | 80px | 80px |
At 800px wide | Name | Before | After | |--------------|--------|-------| | Small | 40px | 40px | | Medium | 50px | 50px | | Large | 44px | 40px | | 2X-Large | 114px | 93px | | 3X-Large | 114px | 106px |
At 1320px wide | Name | Before | After | |--------------|--------|-------| | Small | 40px | 50px | | Medium | 60px | 60px | | Large | 73px | 80px | | 2X-Large | 120px | 120px | | 3X-Large | 160px | 160px |
At 1920px wide | Name | Before | After | |--------------|--------|-------| | Small | 40px | 50px | | Medium | 60px | 60px | | Large | 80px | 80px | | 2X-Large | 120px | 120px | | 3X-Large | 160px | 160px |

How to test the changes in this Pull Request:

  1. Make sure the values still work in the editor
  2. Check child themes, make sure nothing is broken