WordPress / wporg-parent-2021

21 stars 11 forks source link

Non-translatable strings in the news section and single post #121

Closed marcarmengou closed 10 months ago

marcarmengou commented 10 months ago

Strings that cannot be translated appear in the /news/ section of any locale.

1 2

3

ryelle commented 10 months ago

These pages are controlled by the parent theme (which is why I moved this issue). It looks like the parent theme's strings were not being imported into GlotPress. I've updated that, and made the other strings on News translatable, so those should show up soon.

I should have a fix for "By [author]" tomorrow.

marcarmengou commented 10 months ago

Thanks, the strings are already listed as translatable.

ryelle commented 10 months ago

Okay, I've added the By %s string so that the author prefix is translatable too. Everything here should be ready now.

The text inside the subscribe form comes from Jetpack though, so they'll need to be translated in the plugin project.

marcarmengou commented 10 months ago

Thank's @ryelle . Is it normal that the strings, already translated in GlotPress, still do not appear translated in all locale sites?

The strings in Jetpack's Subscribe block have been translated since August, in my locale, but they still appear in English. In fact, I see the same thing happening in all the locales.

ryelle commented 10 months ago

I'm not sure, maybe it has something to do with the strings coming from block attributes. It looks like we can pass in our own strings to the block, so that might be the simplest fix.

marcarmengou commented 10 months ago

Thanks @ryelle I think we can close this. The translated strings already appear in the locales /news/ and those of Jetpack's subscribe block as well.