search

WordPress / wporg-parent-2021

17 stars 10 forks source link

Add cursor: pointer for `<button>`s. #137

Closed StevenDufresne closed 4 months ago

StevenDufresne commented 4 months ago

I'm working on Accessibility: Plugin single links and buttons missing hover states #263.

That converted classic to block theme uses <button> and <input> elements in various places for form submission.

In order to make those look the same as the new parent style, we've added wp-block-button__link to the elements and visual they are working. 👍

The only difference is that we have cursor: pointer added to anchor tags in this parent theme and therefore we get inconsistent hover states between <a> and <button|input> links.

This PR adds the cursor: pointer to the button as well. I can't think of a scenario where this wouldn't make sense.

StevenDufresne commented 4 months ago

That's great context and I appreciate the share.

I personally find it weird that links are styled like buttons in modern web design as well.

I'm also not opposed to figuring out a different visual indicator for actual buttons that are included in forms. Maybe there's a convention we can come up with form themselves in the future to denote that the button submits a form; be it color, outline, etc..

I'll merge this now to make the UI more consistent in the button/link sense but very open to future iterations.