WordPress / wporg-parent-2021

21 stars 11 forks source link

New Theme: 404 page, links too dark #148

Open bph opened 4 months ago

bph commented 4 months ago

Type of feedback

//dev

Description

On the 404 page, links offered are barely readable as they have color contrast issues with middle blue on black background.

Step-by-step reproduction instructions (optional)

Go to 404 page

Screenshots or screen recording (optional)

Screenshot 2024-07-16 at 17 42 21

adamwoodnz commented 4 months ago

I've run an accessibility scan on the page and the links do meet the WCAG 2.1 AA minimum contrast ratio. I'm not sure what other color we would use here. @WordPress/meta-design what are your thoughts please?

Noting that the standard 404 page used across much of WordPress.org has the same design.

adamwoodnz commented 4 months ago

https://webaim.org/resources/contrastchecker/?fcolor=7B90FF&bcolor=23282D

Image

bph commented 4 months ago

Despite what computer tools find 'adequate', it's not particular helpful for the lost soul (= the reader who lands on this page) to not get enough consideration to make the choices of alternative pages more prominent, or at least more readable.

That applies also to the standard 404 pages, even if it were deployed a million times before.

fcoveram commented 4 months ago

That color is used for text and the focus ring over dark backgrounds across the site. We can definitely revisit the decision, but to keep the style consistent across the site, we would need to revisit most sections to ensure it doesn't clash with other styles already implemented.

adamwoodnz commented 3 months ago

Transferring to parent theme repo as these styles are not unique to Learn, only the content is different.