search

WordPress / wporg-parent-2021

21 stars 11 forks source link

Increase spacing for h3. #153

Closed StevenDufresne closed 2 months ago

StevenDufresne commented 2 months ago

This PR increases the margin-top for h3, but is reversed when it is immediately preceded by an h2. It's a pretty subtle change overall originally discussed here: https://wordpress.slack.com/archives/C04U953K77A/p1726018656095909.

Screenshots

Not very noticeable in text heavy content

URL: https://wordpress.org/documentation/article/plugins-themes-auto-updates/ Before After
Screenshot 2024-09-12 at 3 36 57 PM Screenshot 2024-09-12 at 3 36 35 PM

More noticeable when elements are combined

URL: https://developer.wordpress.org/news/2024/08/29/registering-block-templates-via-plugins-in-wordpress-6-7/ Before After
Screenshot 2024-09-12 at 3 39 24 PM Screenshot 2024-09-12 at 3 39 42 PM
Before After
Screenshot 2024-09-12 at 3 43 25 PM Screenshot 2024-09-12 at 3 43 36 PM
jasmussen commented 2 months ago

Looks good to me. I'd welcome an additional bit of input from @WordPress/meta-design, but if nothing comes, let's move ahead!

ndiego commented 2 months ago

Looks good to me as well.

fcoveram commented 2 months ago

It looks good to me. Let’s do it