search

WordPress / wporg-theme-directory

12 stars 6 forks source link

Move see all review link under the ratings. #111

Closed StevenDufresne closed 1 month ago

StevenDufresne commented 1 month ago

I find the "see all reviews" link distracting as it's the only right-aligned link that is next to the title in the sidebar.

In this PR I proposed we move it below the reviews which also seems to make the tabbing more logical where you tab through some reviews to reach the "all reviews" link. I wasn't sure which order makes more sense; "add my review" first or "see all reviews" first. I'm open to suggestions on that.

If this change goes in, I'll update the plugin directory to match.

Screenshots

Before After
Screenshot 2024-06-05 at 10 51 01 AM Screenshot 2024-06-05 at 10 50 44 AM

Note: The "after" screenshot data and star ratings don't match as I copied/pasted DOM parts from the live site since my local environment didn't have the ratings table.

ryelle commented 1 month ago

IMO having both links side by side looks very repetitive, of the two options I prefer the top right-aligned link. Maybe just move the "see all" link under the heading?

Screenshot 2024-06-05 at 10 20 53 AM
jasmussen commented 1 month ago

No strong opinions here, happy to try what you feel the strongest for. One suggestion, though, could be this:

Group 1

Note the reduced verbiage.

fcoveram commented 1 month ago

I like @jasmussen's idea, and I would increase the spacing between the two links and the bars area to make the difference more clear.

StevenDufresne commented 1 month ago

Update layout in 40691ee.

Mobile Desktop
Screenshot 2024-06-12 at 11 07 24 AM Screenshot 2024-06-12 at 11 07 31 AM
jasmussen commented 1 month ago

Works for me!