WordPress / wporg-theme-directory

12 stars 6 forks source link

Playground Previews #118

Closed dd32 closed 2 weeks ago

dd32 commented 1 month ago

See #14

This is a companion to https://github.com/WordPress/wordpress.org/pull/329 exploring adding Theme Previews using Playground to the new theme.

Notes:

This is actually a very small change code-wise, but the user-experience is not at all ideal IMHO, based on the load times.

dd32 commented 2 weeks ago

After this is merged, you'll be able to compare these two urls:

dd32 commented 2 weeks ago

@ryelle This has removed the Invalid URL: The preview could not be loaded. notice and code, but I'm not sure why it exists in the first place.

Is this fine to do? Is there an edge-case that I'm not aware of that we care about?

ryelle commented 2 weeks ago

This has removed the Invalid URL: The preview could not be loaded. notice and code, but I'm not sure why it exists in the first place.

Is this fine to do? Is there an edge-case that I'm not aware of that we care about?

I added it assuming we would want to avoid showing non-wporg sites in the previewer, but never followed up to see if that was even possible from the plugin code— so no, I was just trying to be extra-cautious.