search

WordPress / wporg-theme-directory

12 stars 6 forks source link

"Help translate" bar is very big #136

Closed jasmussen closed 4 weeks ago

jasmussen commented 4 weeks ago

On the them directory landing page, the language bar is 32px tall and blue and 12px font size:

Image

On the theme directory, language bar (which includes here a "help translate" CTA) is 54px tall and yellow 14px font size:

Image

It's clear that the language bars are different types; one is for the directory itself, one is for the theme and with a translation contribution callout. This fact suggests that we should likely redesign, more holistically, the latter.

But in the mean time, can we unify the height and font sizes?

Can it also be "Help improve the translation." instead of "Help improve the translation!" (exclamation to period)?

ryelle commented 4 weeks ago

@jasmussen This "prominent style" was added for the Plugin Directory, approved by @fcoveram (see see https://github.com/WordPress/wordpress.org/issues/301). I've updated this in the theme directory to match the behavior: a small banner on archives/pages, and a larger banner on single plugins.

Should it change back in both places? Just on themes? Do you have a proposal for a better "prominent" banner?

jasmussen commented 4 weeks ago

I didn't see that, sorry about that. I'm happy to defer to Francisco; I do think it's a little big, but I'm also happy to try keeping it as is. The alternative as I alluded to in the issue here is to rethink: what is the goal of this "help translate" bar, and could it live elsewhere, perhaps as a CTA in the sidebar? Given the ping, Francisco will have a chance to see this when he's back from AFK, and share his thoughts. So feel free to close this one in the mean time if that's the preference, then we can open a new issue depending on where we land.

ryelle commented 4 weeks ago

Okay, I'll close this. The language suggestion banner lives in wporg-mu-plugins, so if you decide to change it, open a new issue there.