Previewer: Unnecessary horizontal scrollbars

WordPress / wporg-theme-directory

12 stars 6 forks source link

Previewer: Unnecessary horizontal scrollbars #140

Closed youknowriad closed 3 weeks ago

youknowriad commented 3 weeks ago

Describe the bug

If you have "scrollbars always visible" enabled on MacOS (or in Windows I'm guessing), you'll see horizontal scrollbars in the sidebar of the previewer.

Also, a black border is visible at the right of the sidebar which seems unnecessary.

To Reproduce

Enable "scrollbars always visible" on MacOs settings.
Open https://wordpress.org/themes/twentytwentyfour/preview/

Expected behavior

No horizontal scrollbars and no black border on the right of the sidebar.

Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser Safari or Chrome

ryelle commented 3 weeks ago

Thanks for flagging the scrollbar issue :)

Also, a black border is visible at the right of the sidebar which seems unnecessary.

The off-black border is there for separation when in the loading state, or viewing a theme with a dark color scheme.

Loading	Dark colors

youknowriad commented 3 weeks ago

Thanks for the quick fix.

How do releases work? When does the site get updated?

ryelle commented 3 weeks ago

It should be updated already — it's a manual deployment from a sandbox, but I pushed it right after that commit.

youknowriad commented 3 weeks ago

Mmm, I'm actually still seeing the horizontal scrollbars using the link in the issue.

ryelle commented 3 weeks ago

You are correct… looks like the version isn't set correctly so it's serving the old CSS.

ryelle commented 3 weeks ago

Fixed the version string so it should be serving the correct CSS now.

youknowriad commented 3 weeks ago

Great. Thank you :)