search

WordPress / wporg-theme-directory

15 stars 6 forks source link

New Theme: No screenshot in embed template #46

Closed ryelle closed 2 months ago

ryelle commented 3 months ago

The current theme has a custom embed template, which includes the theme screenshot.

Current theme Block theme
Screen Shot 2024-04-30 at 18 56 47-fullpage Screen Shot 2024-04-30 at 18 56 41-fullpage
ryelle commented 3 months ago

@dd32 Thanks for flagging! This makes sense to bring back to the block theme, do you think it needs more discussion?

dd32 commented 3 months ago

I don't think this needs discussion; but personally I was wondering if it should be tweaked to match the new style slightly more.. mostly the large image is questionable I felt.

Only thing worth noting is that the image should either not be linked, or have it's alt tag set appropriately; ref: https://github.com/WordPress/wordpress.org/pull/136