Theme Directory Redesign: H1 size is very small

[mathetos]

Describe the bug The H1 for the new Theme Directory feels very small.

The size is currently set at as var(--wp--preset--font-size--heading-5) which is the second smallest heading size in terms of the variables in the stylesheet

Suggested Change It seems the H1 should be var(--wp--preset--font-size--heading-1), but that feels a bit large.

I'm suggesting to use var(--wp--preset--font-size--heading-2) instead of var(--wp--preset--font-size--heading-5)

Here's what that looks like:

Additional context It kind of begs the question of why the variables for font-size are set the way they are if they aren't sufficient for the actual H1 on the screen.

[ryelle]

Hello, thanks for checking out the theme preview! This hasn't gone through any design review process yet, so these font sizes are pretty much placeholder at the moment. I've already heard from @WordPress/meta-design that they plan to do a typography review, so maybe we can use this issue to discuss the typography on the Theme Directory holistically.

It kind of begs the question of why the variables for font-size are set the way they are if they aren't sufficient for the actual H1 on the screen.

This type scale is used across the entire WordPress.org network, and in some cases we do want the fonts to be this big (the homepage, About subpages, etc), and they're used as-is there. In other areas of the site, that size is too large, so we just scale it down. I probably went too far with heading-5 here, heading-3 would match the current font-size of 36px.

[jasmussen]

Good issue, reasonable. The context for the current heading size is this exploration:

36px feels like a good size for this heading. The thing to also be mindful of is to be responsible with the density and whitespace, so it doesn't push good content too far down. To that end, 36 is probably a good place to start, and then we can go from there.