search

WordPress / wporg-theme-directory

16 stars 7 forks source link

Increase darkness of `.wp-block-wporg-screenshot-preview` border. #92

Closed StevenDufresne closed 4 months ago

StevenDufresne commented 4 months ago

Describe the bug The border on .wp-block-wporg-screenshot-preview is light-grey-2 which doesn't match the screenshot border and is too light, especially when the pattern or style variations have a white background.

Before After
Screenshot 2024-05-24 at 10 00 50 AM Screenshot 2024-05-24 at 10 00 42 AM
Screenshot 2024-05-24 at 10 00 11 AM Screenshot 2024-05-24 at 10 00 28 AM

Theme Link: https://wordpress.org/themes/twentytwentyfour/

ryelle commented 4 months ago

@WordPress/meta-design What do you think? It looks like we have a few different borders going on on this page. The main screenshot uses black at 15% opacity, currently the style variations and patterns use light-grey-2 (which matches the grey background on patterns now (not on the preview yet)), and light-grey-1 is used on the meta & variation nav arrows.

Screen Shot 2024-05-31 at 17 21 02

If we switch style variations and patterns to light-grey-1, they'll be more consistent at least.

Screen Shot 2024-05-31 at 17 32 53

jasmussen commented 4 months ago

Light gray 1 works, good to unify this, good issue.

fcoveram commented 4 months ago

Agree with @jasmussen, it looks good