WordPress / wporg-theme-directory

12 stars 6 forks source link

Theme hover style: Unify with Plugin directory #96

Closed jasmussen closed 1 month ago

jasmussen commented 1 month ago

The hover style in the theme directory is a black border:

Image

In the plugin directory, it's a gray background:

Image

We should update so these are the same. I'd recommend trying to absorb the plugin directory style in the theme directory. It's mostly decorative, after all, and it might be less confusing as far as focus styles.

ryelle commented 1 month ago

Should I also revert the charcoal border suggested here https://github.com/WordPress/wporg-theme-directory/issues/83? Does this impact the hover state of the pattern and style cards?

jasmussen commented 1 month ago

I hadn't seen that, thanks for bringing it up. I wouldn't want to undo @fcoveram's suggestion, so we can go the other direction too, update the plugin directory hover style to be similar to this.

fcoveram commented 1 month ago

Sorry for the lack of coordination. I agree with updating the plugin directory to inherit the border behavior.

ryelle commented 1 month ago

Works for me 😄 I'll close this and you can open an issue in https://github.com/WordPress/wordpress.org for updating the plugin directory. Should the Pattern Directoy also be updated? (would be another issue in https://github.com/WordPress/pattern-directory/)

jasmussen commented 1 month ago

Moved to https://github.com/WordPress/wordpress.org/issues/324. Pattern directory let's leave as is for now, it's a slightly more unique case, the gray background works well there, but that wouldn't work for themes and plugins.