search

WordPress / wporg-theme-directory

16 stars 7 forks source link

Improve Pattern previews in new theme #98

Closed ndiego closed 4 months ago

ndiego commented 4 months ago

The pattern previews for themes did not change in the new theme design, but I am wondering if we should update them to closer resemble the new Pattern directory redesign. I am not sure we need as much grey border, but I like how the patterns are vertically centered in the container.

New theme (Frost) Pattern Directory
image image
ryelle commented 4 months ago

What do you think about this? I added the grey background because it needed something to frame it, but left the current hover effect (border change rather than background) to match the style variation cards.

Screenshot 2024-05-30 at 5 34 03 PM

Top middle has the hover effect

In the previewer, still cropped and centered, but smaller spacing around the images.

Screenshot 2024-05-30 at 5 35 29 PM
ndiego commented 4 months ago

I love it! What do you think @WordPress/meta-design?

jasmussen commented 4 months ago

Sure, that works.

fcoveram commented 4 months ago

I like how both with the gray background and the one in the previewer. Is the dark border in hover the same as the one discussed in #96? It looks thinner to me but it could be the screenshot on my browser.

ryelle commented 4 months ago

The dark border is what's currently on production, I didn't change anything there. So I think it's just the screenshot, if what's on production is good.

ryelle commented 4 months ago

It turns out the color is wrong on production, it's charcoal-5 there, but should be charcoal-1. So I'll also update that 🙂