search

WordPress / wporg-two-factor

2FA for WordPress.org accounts
38 stars 8 forks source link

Add copy/print/download buttons to code backup. #284

Closed StevenDufresne closed 4 months ago

StevenDufresne commented 4 months ago

Fixes: https://github.com/WordPress/wporg-two-factor/issues/45

This PR adds a copy, print, and download button to the backup code page.

The only downside is that @wordpress/icons doesn't have a print icon and we get a weird layout if we combine <Icon> with <Dashicon>, so I've started with using dashicons.

@WordPress/meta-design Do we have a print <svg> that I can use?

Screenshot

Screenshot 2024-07-10 at 1 39 53 PM
jasmussen commented 4 months ago

There should be both copy and download icons, and I'm happy to help with a print icon. However in this case, the action item row here feels like it could easily afford giving slightly more prominence to those buttons, so you could simply spell out copy, print, download as labels.

Should it also be "Done" instead of "All Finished"? Otherwise, probably sentence case, "All finished".

StevenDufresne commented 4 months ago

Should it also be "Done" instead of "All Finished"? Otherwise, probably sentence case, "All finished".

Yeah, that's a good update. I don't know where that copy came from originally.

StevenDufresne commented 4 months ago

Alright, I replaced the icons with text.