WordPress / wporg-two-factor

2FA for WordPress.org accounts
35 stars 7 forks source link

Prevent changing 2FA settings through wp-admin #52

Open iandunn opened 1 year ago

iandunn commented 1 year ago

We already hide the UI that the two-factor plugin adds to profile.php, but our custom UI also includes password/email, and those are still in wp-admin/buddypress/bbpress/etc.

there's a lot of settings on wp-admin/profile.php that should not be changed there, and in the case of WordCamp, will cause the WordPress.org user data to get out of sync with the database. https://github.com/WordPress/wporg-two-factor/issues/13#issuecomment-1317931757

We might need to delay this while #114 is still using wp-admin, before the custom UI is built.

dd32 commented 1 year ago

I've gone back and forth on this, the wp-admin profile page is not accessible by most users, but is still required for Application Passwords (As used by the PHPUnit Test Reporters).

It feels like a complete hack, but filters and blocking change attempts doesn't seem to be worth it, and I don't like the look of the code.. so.. I'm super temped to just deploy some Javascript to remove the fields we don't want changed, along with a big banner.. That's what has resulted in me making #54.