Closed keien closed 10 years ago
Yes.
The original (as does ours) has code to remove dependencies with ROOT
. ROOT
has an index of 0
. The original code had an off-by-one error which removed all dependencies in which one or more words had an index of 1
or less instead of 0
or less.
So, in this case, the original would have removed the first, third, and fifth dependencies - the third and the fifth are the ones missing from the database query.
Got it, thanks for confirming.
I'm running some basic tests on the personal ads dataset that Aditi sent me, and I found an interesting inconsistency in the dependencies. When I queried the SQL dump directly, I got these first couple dependencies:
from the sentence, "Thanks a lot to open my ad. " (it's the first sentence of the first ad document).
Now, when I tried parsing the sentence directly using
raw_parse
, I get this:I know the root dependency gets removed, but that still leaves two extra dependencies that the original doesn't have. Do you know why that is?