search

Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
40 stars 16 forks source link

Removing readerwriter #133

Closed keien closed 10 years ago

keien commented 10 years ago

ReaderWriter finally removed

keien commented 10 years ago

I don't understand how the previous commit passed the Travis tests, then I remove two files, and suddenly it doesn't work again.

abendebury commented 10 years ago

You might have had some .pyc files left over.

alias cleanpyc='find . -name \*.pyc -delete && find . -name __pycache__ -delete'
keien commented 10 years ago

How does that affect the Travis build? The .pyc files don't get uploaded to the repo

abendebury commented 10 years ago

Right - if the build isn't failing for you locally, that could be why.

abendebury commented 10 years ago

Strange, it's failing for me locally. I'll try restarting the travis build.

abendebury commented 10 years ago

Seems to be one of the StructureExtractor unit tests that's messing everything up.

abendebury commented 10 years ago

Specifically an issue in StructureExtractor.extract_unit_information().

abendebury commented 10 years ago

Specifically, this line.

keien commented 10 years ago

How can you tell? I have no way of checking this myself.

abendebury commented 10 years ago

Commenting out that one line prevents the SQLAlchemy error from occurring (other errors occur of course). Are you still unable to reproduce? Did you try a different python version?

keien commented 10 years ago

Yeah I don't seem to be able to reproduce it at all.

abendebury commented 10 years ago

Maybe we should unmerge sentence_error_handling and just merge remving-readerwriter into `master.

keien commented 10 years ago

If we do that then the pipeline won't work properly anymore. Also, didn't removing-readerwriter already have this problem anyway?

What if we merge master into removing-readerwriter?

abendebury commented 10 years ago

removing-readerwriter passed tests iirc. Yeah, we can merge in master

keien commented 10 years ago

I'll do that after this personals run finishes

abendebury commented 10 years ago

Rolling back is looking good - I'll push that soon. Then we should fix the readerwriter tests that have been skipped for now then we can merge this to master.

abendebury commented 10 years ago

I think what happened was that we have a lot more files interacting with the database, but we didn't write their unit tests keeping that in mind so there was junk left over in the session.

abendebury commented 10 years ago

@ikenohate09 #141 is the last outstanding issue, once we fix that I'll merge.