search

Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
42 stars 16 forks source link

Remove extra methods in CollectionProcessor #141

Closed abendebury closed 10 years ago

abendebury commented 10 years ago

https://github.com/Wordseer/wordseer_flask/blob/removing-readerwriter/app/preprocessor/collectionprocessor.py#L78

Some of these are unnecessary, I think, but I'm not sure which those are.

abendebury commented 10 years ago

I'll remove the unit tests since they aren't testing anything right now, but I'll leave this issue open since it's unclear what needs to happen to these methods.

abendebury commented 10 years ago

It's actually more than just CollectionProcessor: https://github.com/Wordseer/wordseer_flask/blob/master/app/preprocessor/sequenceprocessor.py#L203

keien commented 10 years ago

fixed in 487991b

abendebury commented 10 years ago

What about all these methods?

keien commented 10 years ago

We can move this line there since that's where it's supposed to be and we should open separate issues for tf-idfs and word similarities; as far as extra methods go, there aren't anymore of them.

abendebury commented 10 years ago

Sounds good.