search

Wordseer / wordseer

The WordSeer text analysis tool, written in Flask.
http://wordseer.berkeley.edu/
42 stars 16 forks source link

grammaticalsearch shouldn't concatenate metadata values #168

Open macfarlandian opened 10 years ago

macfarlandian commented 10 years ago

currently when there are multiple values associated with a metadata property key, they are returned with sentence search results as a concatenated string rather than a list, so they can't be differentiated on the front end. for an example, see any document with multiple Authors or Categories in the "acm" instance.

the items should be kept separate, and we'll update the JS to handle that.

abendebury commented 10 years ago

If I remember, there are lots of... strange cases where a sequence of things is returned as a concatenated comma separated list or something.

I think we should just make it a rule that whenever we are returning several things we should be returning a list to keep things simple.

macfarlandian commented 10 years ago

yeah, there are definitely some with how the structure of metadata is represented in API responses ... in some places it's returned as substrings of name, type, value, and other things delimited by "__" ... you might as well clean up things like that if you are starting from scratch anyway.

On Fri, Aug 15, 2014 at 3:59 PM, PlasmaSheep notifications@github.com wrote:

If I remember, there are lots of... strange cases where a sequence of things is returned as a concatenated comma separated list or something.

I think we should just make it a rule that whenever we are returning several things we should be returning a list to keep things simple.

— Reply to this email directly or view it on GitHub https://github.com/Wordseer/wordseer_flask/issues/168#issuecomment-52370182 .